Enhance observability in core modules via descriptive error handling#5195
Open
saishmungase wants to merge 1 commit intosugarlabs:masterfrom
Open
Enhance observability in core modules via descriptive error handling#5195saishmungase wants to merge 1 commit intosugarlabs:masterfrom
saishmungase wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
Hi team, I’ve updated the PR to resolve the CI check for the translation files. This implementation fully addresses the requirements outlined in Issue #5194 by:
Ready for review! Thanks. |
Contributor
|
@saishmungase resolve merge conflicts. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
saishmungase
force-pushed
the
chore/refactor-error-logs
branch
from
cd029cf to
83c5c8d
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
Hi everyone! I wanted to give a quick update. I’ve fixed the merge conflicts, and the branch is fully up to date. Let me know if you need anything else from me. Thank you for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone!
While working through the core modules, I noticed several instances where JSON parsing or state restoration failures were being "swallowed" by generic console logs. This makes debugging difficult, especially as we look toward porting logic for the v4 foundational rebuild.
What this PR does:
console.log(e)with descriptive strings (e.g.,"Error clearing palettes:"or"ProjectStorage: Failed to parse JSON data for key...").console.error()so issues are correctly categorized in dev tools.// eslint-disable-next-line no-consoleworkarounds, ensuring we follow the project's linting standards without overrides.Verification:
I've run the full test suite locally:
The refactored logs were triggered during test runs (e.g., in
palette.test.js), confirming that the added context is appearing correctly in the output.Closes #5194